Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Improve permissions check on im endpoints #32333

Merged
merged 20 commits into from
May 13, 2024
Merged

chore!: Improve permissions check on im endpoints #32333

merged 20 commits into from
May 13, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Apr 29, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Improve permissions check on im endpoints by using the permissionsRequired property.

Issue(s)

CORE-340

Steps to test or reproduce

Further comments

The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Apr 29, 2024
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 29, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e696d53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matheusbsilva137 matheusbsilva137 changed the title chore: Improve permissions check on im endpoints chore!: Improve permissions check on im endpoints Apr 29, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.53%. Comparing base (a3e9e9b) to head (e696d53).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #32333      +/-   ##
=================================================
+ Coverage          54.41%   55.53%   +1.11%     
=================================================
  Files               2325     2405      +80     
  Lines              51772    52926    +1154     
  Branches           10654    10872     +218     
=================================================
+ Hits               28172    29390    +1218     
+ Misses             21090    20929     -161     
- Partials            2510     2607      +97
Flag Coverage Δ
e2e 54.84% <ø> (+2.13%) ⬆️
unit 73.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review April 29, 2024 23:21
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner April 29, 2024 23:21
ggazzo and others added 11 commits May 7, 2024 10:38
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners May 7, 2024 13:39
ggazzo pushed a commit that referenced this pull request Aug 16, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
6a5e4ba
ggazzo pushed a commit that referenced this pull request Sep 5, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
3702d8e
ggazzo pushed a commit that referenced this pull request Sep 5, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
00061f3
ggazzo pushed a commit that referenced this pull request Sep 5, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
25bd12c
ggazzo pushed a commit that referenced this pull request Sep 11, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
8cdf9d6
ggazzo pushed a commit that referenced this pull request Sep 13, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
6573c07
ggazzo pushed a commit that referenced this pull request Sep 13, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
652168e
ggazzo pushed a commit that referenced this pull request Sep 14, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
e089227
ggazzo pushed a commit that referenced this pull request Sep 16, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
58626de
MartinSchoeler pushed a commit that referenced this pull request Sep 18, 2024
@matheusbsilva137 @MartinSchoeler
chore!: Improve permissions check on im endpoints (#32333)
9e8d9d7
ggazzo pushed a commit that referenced this pull request Sep 25, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
707b65e
ggazzo pushed a commit that referenced this pull request Sep 25, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
5732b88
ggazzo pushed a commit that referenced this pull request Sep 27, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
c179010
ggazzo pushed a commit that referenced this pull request Sep 27, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
294b21d
gabriellsh pushed a commit that referenced this pull request Oct 7, 2024
@matheusbsilva137 @gabriellsh
chore!: Improve permissions check on im endpoints (#32333)
13a3051
ggazzo pushed a commit that referenced this pull request Oct 8, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
4a63890
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
@matheusbsilva137 @sampaiodiego
chore!: Improve permissions check on im endpoints (#32333)
f892ead
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
@matheusbsilva137 @sampaiodiego
chore!: Improve permissions check on im endpoints (#32333)
cddfb0f
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
@matheusbsilva137 @abhinavkrin
chore!: Improve permissions check on im endpoints (#32333)
fdcd756
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
7863e03
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
31edce6
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
ee3a09a
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
773242f
yash-rajpal pushed a commit that referenced this pull request Oct 14, 2024
@matheusbsilva137 @yash-rajpal
chore!: Improve permissions check on im endpoints (#32333)
2bfc1ca
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
f58d3de
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
@matheusbsilva137 @MartinSchoeler
chore!: Improve permissions check on im endpoints (#32333)
0e2b40e
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
25b3b0b
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
c237ec4
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
@matheusbsilva137 @ggazzo
chore!: Improve permissions check on im endpoints (#32333)
95460bf
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
@matheusbsilva137 @abhinavkrin
chore!: Improve permissions check on im endpoints (#32333)
ebfc6e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@KevLehman KevLehman Awaiting requested review from KevLehman

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matheusbsilva137 @KevLehman @MarcosSpessatto @ggazzo @pierre-lehnen-rc